Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shell scripts to have more reuse #830

Merged
merged 13 commits into from
May 27, 2024
Merged

Conversation

stephanmantel
Copy link
Contributor

No description provided.

In stead of having to repeat the command for every folder,
we can iterate over a list of them and execute the same
command over and over again.

This also fixes the SC2164 warning that was present.
In case it was not yet executable.
It makes it only executable on user level
Running the build_runner on every module.
This replaces the existing individual generation scripts.
Those modules without anything to generate will just output
"Could not find package `build_runner` or file `build_runner`"
and continue to the next, which is fine.
Copy link
Collaborator

@dkaera dkaera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephanmantel stephanmantel merged commit aab7264 into develop May 27, 2024
2 of 6 checks passed
@stephanmantel stephanmantel deleted the tools_scripts branch May 27, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants